zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix two dependencies with silo. (#9153)

Browse Source 
1. I presently get errors of the sort

==> Error: KeyError: 'No spec with name mpi in silo@4.10.2%gcc@8.1.0+fortran+mpi
[...]
$HOME/spack/var/spack/repos/builtin/packages/silo/package.py:84, in configure_args:
         81                'FCFLAGS={0}'.format(self.compiler.pic_flag)]
         82
         83        if '+mpi' in self.spec:
  >>     84            config_args.append('CC=%s' % self.spec['mpi'].mpicc)
         85            config_args.append('CXX=%s' % self.spec['mpi'].mpicxx)
         86            config_args.append('FC=%s' % self.spec['mpi'].mpifc)

without the extra explicit MPI dependency.

2. Silo uses zlib, so we should explicitly depend on it.
This commit is contained in:
David Wells 2018-09-03 10:43:00 -04:00 committed by Massimiliano Culpo
parent 940e35059e
commit 734d6306a2
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
var/spack/repos/builtin/packages/silo/package.py
View File

@ -48,8 +48,10 @@ class Silo(AutotoolsPackage):
description='Compile with MPI Compatibility')
depends_on('hdf5~mpi', when='~mpi')
depends_on('mpi', when='+mpi')
depends_on('hdf5+mpi', when='+mpi')
depends_on('qt', when='+silex')
depends_on('zlib')
patch('remove-mpiposix.patch', when='@4.8:4.10.2')