Implement review requests

- use two empty lines before `class`
- change version numbering scheme for packages, use `url_for_version` to make things work
- specify dependency types
- add comment about temporarily moved download location
- update two packages to newer versions

var/spack/repos/builtin/packages/lrslib/package.py

@@ -25,24 +25,28 @@
 
 from spack import *
 
+
 class Lrslib(Package):
     """lrslib Ver 6.2 is a self-contained ANSI C implementation of the
     reverse search algorithm for vertex enumeration/convex hull
     problems and comes with a choice of three arithmetic packages"""
     homepage = "http://cgm.cs.mcgill.ca/~avis/C/lrs.html"
     url      = "http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-062.tar.gz"
+    def url_for_version(self, version):
+        return ("http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-%s.tar.gz" %
+                ('0' + str(version).replace('.', '')))
 
-    version('062', 'be5da7b3b90cc2be628dcade90c5d1b9')
-    version('061', '0b3687c8693cd7d1f234a3f65e147551')
-    version('060', 'd600a2e62969ad03f7ab2f85f1b3709c')
-    version('051', 'cca323eee8bf76f598a13d7bf67cc13d')
-    version('043', '86dd9a45d20a3a0069f77e61be5b46ad')
+    version('6.2', 'be5da7b3b90cc2be628dcade90c5d1b9')
+    version('6.1', '0b3687c8693cd7d1f234a3f65e147551')
+    version('6.0', 'd600a2e62969ad03f7ab2f85f1b3709c')
+    version('5.1', 'cca323eee8bf76f598a13d7bf67cc13d')
+    version('4.3', '86dd9a45d20a3a0069f77e61be5b46ad')
 
     # Note: lrslib can also be built with Boost, and probably without gmp
 
     # depends_on("boost")
     depends_on("gmp")
-    depends_on("libtool")
+    depends_on("libtool", type="build")
 
     patch("Makefile.spack.patch")