Bug Fix: Better incremental check for CMake (#48775)

* Bug Fix: Better incremental check for CMake

* Fix syntax error

* Ensure match of config artifact with generator
This commit is contained in:
psakievich 2025-01-31 07:48:41 -07:00 committed by GitHub
parent 7ebabfcf0e
commit 759518182c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -459,8 +459,16 @@ def cmake(
"""Runs ``cmake`` in the build directory"""
# skip cmake phase if it is an incremental develop build
# These are the files that will re-run CMake that are generated from a successful
# configure step
primary_generator = _extract_primary_generator(self.generator)
if primary_generator == "Unix Makefiles":
configure_artifact = "Makefile"
elif primary_generator == "Ninja":
configure_artifact = "ninja.build"
if spec.is_develop and os.path.isfile(
os.path.join(self.build_directory, "CMakeCache.txt")
os.path.join(self.build_directory, configure_artifact)
):
return