diff --git a/.github/workflows/valid-style.yml b/.github/workflows/valid-style.yml index 6b85f5d0c67..152b8823da1 100644 --- a/.github/workflows/valid-style.yml +++ b/.github/workflows/valid-style.yml @@ -121,31 +121,14 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 with: repository: haampie/circular-import-fighter - ref: b5d6ce9be35f602cca7d5a6aa0259fca10639cca + ref: 9a2c728c97f594dec0210e7f85cb7167eaf29176 path: circular-import-fighter - name: Install dependencies working-directory: circular-import-fighter run: make -j dependencies - - name: Problematic imports before + - name: Circular import check working-directory: circular-import-fighter - run: make SPACK_ROOT=../old SUFFIX=.old - - name: Problematic imports after - working-directory: circular-import-fighter - run: make SPACK_ROOT=../new SUFFIX=.new - - name: Compare import cycles - working-directory: circular-import-fighter - run: | - edges_before="$(head -n1 solution.old)" - edges_after="$(head -n1 solution.new)" - if [ "$edges_after" -gt "$edges_before" ]; then - printf '\033[1;31mImport check failed: %s imports need to be deleted, ' "$edges_after" - printf 'previously this was %s\033[0m\n' "$edges_before" - printf 'Compare \033[1;97m"Problematic imports before"\033[0m and ' - printf '\033[1;97m"Problematic imports after"\033[0m.\n' - exit 1 - else - printf '\033[1;32mImport check passed: %s <= %s\033[0m\n' "$edges_after" "$edges_before" - fi + run: make -j compare "SPACK_ROOT=../old ../new" # Further style checks from pylint pylint: