intel compiler: fix link time error with LLVMgold.so (#28731)

The Intel compiler will, at link time, call `ld -plugin LLVMgold.so`, which
expects libraries like `libimfo.so` to be found either in the `LD_LIBRARY_PATH` or
in `LLVMgold.so`s RPATH.

As `LLVMgold.so` already uses RUNPATH, I used that to extend this to the
necessary library locations.

This PR should fix issues:
https://github.com/spack/spack/issues/10308
https://github.com/spack/spack/issues/18606
https://github.com/spack/spack/issues/17100
https://github.com/spack/spack/issues/21237
https://github.com/spack/spack/issues/4261

Co-authored-by: Stephen Sachs <stesachs@amazon.com>

var/spack/repos/builtin/packages/intel-parallel-studio/package.py

@@ -13,6 +13,8 @@ class IntelParallelStudio(IntelPackage):
 
     maintainers = ['rscohn2']
 
+    depends_on('patchelf', type='build')
+
     # As of 2016, the product comes in three "editions" that vary by scope.
     #
     # In Spack, select the edition via the version number in the spec, e.g.:

var/spack/repos/builtin/packages/intel/package.py

@@ -15,6 +15,8 @@ class Intel(IntelPackage):
     # Robert Cohn
     maintainers = ['rscohn2']
 
+    depends_on('patchelf', type='build')
+
     # Same as in ../intel-parallel-studio/package.py, Composer Edition,
     # but the version numbering in Spack differs.
     version('20.0.4',              sha256='ac1efeff608a8c3a416e6dfe20364061e8abf62d35fbaacdffe3fc9676fc1aa3', url='https://registrationcenter-download.intel.com/akdlm/irc_nas/tec/17117/parallel_studio_xe_2020_update4_composer_edition.tgz')