Revert "CI: Disable downloading artifacts from upstream jobs (#41432)" (#41843)

This reverts commit a43156a861.

lib/spack/spack/ci.py

@@ -1253,7 +1253,6 @@ def main_script_replacements(cmd):
                 op=lambda cmd: cmd.replace("mirror_prefix", temp_storage_url_prefix),
             )
 
-            cleanup_job["dependencies"] = []
             output_object["cleanup"] = cleanup_job
 
         if (
@@ -1277,7 +1276,6 @@ def main_script_replacements(cmd):
                 if buildcache_destination
                 else remote_mirror_override or remote_mirror_url
             )
-            signing_job["dependencies"] = []
 
             output_object["sign-pkgs"] = signing_job
 
@@ -1298,7 +1296,6 @@ def main_script_replacements(cmd):
             final_job["when"] = "always"
             final_job["retry"] = service_job_retries
             final_job["interruptible"] = True
-            final_job["dependencies"] = []
 
             output_object["rebuild-index"] = final_job
 

share/spack/gitlab/cloud_pipelines/.gitlab-ci.yml

@@ -73,7 +73,6 @@ default:
 # Job templates
 ########################################
 .base-job:
-  when: manual
   variables:
     PIPELINE_MIRROR_TEMPLATE: "single-src-protected-mirrors.yaml.in"
     # TODO: We can remove this when we drop the "deprecated" stack