zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bugfix: spack.package.possible_dependencies() should return virtuals

Browse Source 
`spack.package.possible_dependencies()` was forgetting to pass the
`visited` dict to recursive calls; this fixes it
This commit is contained in:
Todd Gamblin 2020-01-03 23:28:53 -08:00
parent 0b1b8c3936
commit 7cfa497912
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/spack/spack/package.py
View File

@ -2154,11 +2154,6 @@ def possible_dependencies(*pkg_or_spec, **kwargs):
See ``PackageBase.possible_dependencies`` for details. See ``PackageBase.possible_dependencies`` for details.
""" """
transitive = kwargs.get('transitive', True)
expand_virtuals = kwargs.get('expand_virtuals', True)
deptype = kwargs.get('deptype', 'all')
missing = kwargs.get('missing')
packages = [] packages = []
for pos in pkg_or_spec: for pos in pkg_or_spec:
if isinstance(pos, PackageMeta): if isinstance(pos, PackageMeta):
@ -2172,8 +2167,7 @@ def possible_dependencies(*pkg_or_spec, **kwargs):
visited = {} visited = {}
for pkg in packages: for pkg in packages:
pkg.possible_dependencies( pkg.possible_dependencies(visited=visited, **kwargs)
transitive, expand_virtuals, deptype, visited, missing)
return visited return visited