zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Warn about removal of deprecated format strings (#33829)

Browse Source 
Co-authored-by: becker33 <becker33@users.noreply.github.com>
This commit is contained in:
Greg Becker
2022-11-22 03:56:57 -06:00
committed by GitHub
parent 793a7bc6a9
commit 7f9af8d4a0
4 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
etc/spack/defaults/config.yaml
View File

@@ -19,7 +19,7 @@ config:
install_tree: install_tree:
root: $spack/opt/spack root: $spack/opt/spack
projections: projections:
all: "${ARCHITECTURE}/${COMPILERNAME}-${COMPILERVER}/${PACKAGE}-${VERSION}-${HASH}" all: "${architecture}/${compiler.name}-${compiler.version}/${name}-${version}-${hash}"
# install_tree can include an optional padded length (int or boolean) # install_tree can include an optional padded length (int or boolean)
# default is False (do not pad) # default is False (do not pad)
# if padded_length is True, Spack will pad as close to the system max path # if padded_length is True, Spack will pad as close to the system max path
@@ -214,4 +214,4 @@ config:
# Number of seconds a buildcache's index.json is cached locally before probing # Number of seconds a buildcache's index.json is cached locally before probing
# for updates, within a single Spack invocation. Defaults to 10 minutes. # for updates, within a single Spack invocation. Defaults to 10 minutes.
binary_index_ttl: 600 binary_index_ttl: 600

5
lib/spack/spack/spec.py
View File

@@ -4418,7 +4418,10 @@ def old_format(self, format_string="$_$@$%@+$+$=", **kwargs):
TODO: allow, e.g., ``$6#`` to customize short hash length TODO: allow, e.g., ``$6#`` to customize short hash length
TODO: allow, e.g., ``$//`` for full hash. TODO: allow, e.g., ``$//`` for full hash.
""" """
tty.warn(
"Using the old Spec.format method."
" This method was deprecated in Spack v0.15 and will be removed in Spack v0.20"
)
color = kwargs.get("color", False) color = kwargs.get("color", False)
# Dictionary of transformations for named tokens # Dictionary of transformations for named tokens

2
lib/spack/spack/test/directory_layout.py
View File

@@ -59,7 +59,7 @@ def test_yaml_directory_layout_parameters(tmpdir, default_mock_concretization):
arch_scheme = ( arch_scheme = (
"{architecture.platform}/{architecture.target}/{architecture.os}/{name}/{version}/{hash:7}" "{architecture.platform}/{architecture.target}/{architecture.os}/{name}/{version}/{hash:7}"
) )
ns_scheme = "${ARCHITECTURE}/${NAMESPACE}/${PACKAGE}-${VERSION}-${HASH:7}" ns_scheme = "${architecture}/${namespace}/${name}-${version}-${hash:7}"
arch_ns_scheme_projections = {"all": arch_scheme, "python": ns_scheme} arch_ns_scheme_projections = {"all": arch_scheme, "python": ns_scheme}
layout_arch_ns = DirectoryLayout(str(tmpdir), projections=arch_ns_scheme_projections) layout_arch_ns = DirectoryLayout(str(tmpdir), projections=arch_ns_scheme_projections)

4
share/spack/qa/configuration/windows_config.yaml
View File

@@ -3,6 +3,6 @@ config:
install_tree: install_tree:
root: $spack\opt\spack root: $spack\opt\spack
projections: projections:
all: '${ARCHITECTURE}\${COMPILERNAME}-${COMPILERVER}\${PACKAGE}-${VERSION}-${HASH}' all: '${architecture}\${compiler.name}-${compiler.version}\${name}-${version}-${hash}'
build_stage: build_stage:
- ~/.spack/stage - ~/.spack/stage