zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: increase tolerance of termios tests (#19456)

Browse Source 
Synchronization on GitHub macOS runners seems to be very slow, and
frequently the foreground/background tests fail due to the race this
causes. This increases the tolerance for slowness a bit more, to allow up
to 4 spurious output lines in the tests.

This should hopefully result in no more false negatives on these tests
for macOS on GitHub.
This commit is contained in:
Todd Gamblin 2020-10-21 18:12:48 -07:00 committed by GitHub
parent e78764caa1
commit 8060cca494
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/spack/spack/test/llnl/util/tty/log.py
View File

@ -432,11 +432,15 @@ def test_foreground_background_output(
# output should contain mostly "on" lines, but may contain an "off"
# or two. This is because the controller toggles echo by sending "v" on
# stdin to the minion, but this is not synchronized with our locks.
# It's good enough for a test, though. We allow at most 2 "off"'s in
# It's good enough for a test, though. We allow at most 4 "off"'s in
# the output to account for the race.
#
# Originally we only allowed 2, but GitHub's macOS runners seem to be
# very slow, and frequently we get 3 "off"'s. Increased limit to 4 to
# account for this. Real errors should still be caught with this limit.
assert (
['forced output', 'on'] == uniq(output) or
output.count("off") <= 2 # if controller_fd is a bit slow
output.count("off") <= 4 # if controller_fd is a bit slow
)
# log should be off for a while, then on, then off