zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

openmpi: does not support "--without-pmix" (#27258)

Browse Source 
Open MPI currently fails to build with scheduler=slurm if +pmix is
not given with a fatal error due to ``config_args +=
self.with_or_without('pmix', ...)`` resulting in --without-pmix.
However, Open MPI's configure points out "Note that Open MPI does
not support --without-pmix."

The PR only adds "--with-pmix=PATH" if +pmix is part of the spec.
Otherwise, nothing is added and Open MPI can fall back to its
internal PMIX sources.

(The other alternative would be to depend on +pmix in for
scheduler=slurm as is done for +pmi.)
This commit is contained in:
TZ 2021-11-09 11:55:56 +01:00 committed by GitHub
parent 2b990b400e
commit 808375429d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
var/spack/repos/builtin/packages/openmpi/package.py
View File

@ -652,7 +652,8 @@ def configure_args(self):
spec['slurm'].prefix)) spec['slurm'].prefix))
else: else:
config_args.extend(self.with_or_without('pmi')) config_args.extend(self.with_or_without('pmi'))
config_args += self.with_or_without('pmix', activation_value='prefix') if spec.satisfies('+pmix'):
config_args.append('--with-pmix={0}'.format(spec['pmix'].prefix))
if spec.satisfies('@3.1.3:') or spec.satisfies('@3.0.3'): if spec.satisfies('@3.1.3:') or spec.satisfies('@3.0.3'):
if '+static' in spec: if '+static' in spec:
config_args.append('--enable-static') config_args.append('--enable-static')