zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unifyfs: Remove the hdf5 variant (examples only) (#26932)

Browse Source 
UnifyFS doesn't actually use HDF5 for anything.  Enabling it only enables
a few examples to be built so it's not actually a dependency of the package.
This commit is contained in:
Chuck Atkins 2021-10-26 03:42:52 -04:00 committed by GitHub
parent bdcbc4cefe
commit 80d8c93452
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
var/spack/repos/builtin/packages/ecp-data-vis-sdk/package.py
View File

@ -92,7 +92,7 @@ def dav_sdk_depends_on(spec, when=None, propagate=None):
dav_sdk_depends_on('parallel-netcdf+shared+fortran', when='+pnetcdf') dav_sdk_depends_on('parallel-netcdf+shared+fortran', when='+pnetcdf')
dav_sdk_depends_on('unifyfs', when='+unifyfs ', propagate=['hdf5']) dav_sdk_depends_on('unifyfs', when='+unifyfs ')
dav_sdk_depends_on('veloc', when='+veloc') dav_sdk_depends_on('veloc', when='+veloc')

11
var/spack/repos/builtin/packages/unifyfs/package.py
View File

@ -26,7 +26,6 @@ class Unifyfs(AutotoolsPackage):
version('0.9.1', sha256='2498a859cfa4961356fdf5c4c17e3afc3de7e034ad013b8c7145a622ef6199a0') version('0.9.1', sha256='2498a859cfa4961356fdf5c4c17e3afc3de7e034ad013b8c7145a622ef6199a0')
variant('auto-mount', default='True', description='Enable automatic mount/unmount in MPI_Init/Finalize') variant('auto-mount', default='True', description='Enable automatic mount/unmount in MPI_Init/Finalize')
variant('hdf5', default='False', description='Build with parallel HDF5 (install with `^hdf5~mpi` for serial)')
variant('fortran', default='False', description='Build with gfortran support') variant('fortran', default='False', description='Build with gfortran support')
variant('pmi', default='False', description='Enable PMI2 build options') variant('pmi', default='False', description='Enable PMI2 build options')
variant('pmix', default='False', description='Enable PMIx build options') variant('pmix', default='False', description='Enable PMIx build options')
@ -48,7 +47,6 @@ class Unifyfs(AutotoolsPackage):
depends_on('openssl@:1') depends_on('openssl@:1')
# Optional dependencies # Optional dependencies
depends_on('hdf5', when='+hdf5')
depends_on('libfabric fabrics=rxm,sockets,tcp', when="^mercury@2:+ofi") depends_on('libfabric fabrics=rxm,sockets,tcp', when="^mercury@2:+ofi")
depends_on('spath~mpi', when='+spath') depends_on('spath~mpi', when='+spath')
@ -81,15 +79,6 @@ def configure_args(self):
spec = self.spec spec = self.spec
args = [] args = []
# UnifyFS's configure requires the exact path for HDF5
def hdf5_compiler_path(name):
if '~mpi' in spec[name]: # serial HDF5
return spec[name].prefix.bin.h5cc
else: # parallel HDF5
return spec[name].prefix.bin.h5pcc
args.extend(self.with_or_without('hdf5', hdf5_compiler_path))
if '+auto-mount' in spec: if '+auto-mount' in spec:
args.append('--enable-mpi-mount') args.append('--enable-mpi-mount')