zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

python: don't run mkdirp in setup_dependent_package (#41603)

Browse Source 
`setup_dependent_package` is not a build phase, it should just set
globals for a package.

It's called during setup of runtime environment of packages, and there
have been reports of it actually failing due to a read only file system
(not sure under what exact conditions that is possible).
This commit is contained in:
Harmen Stoppels 2023-12-13 23:54:28 +01:00 committed by GitHub
parent 84436f10ba
commit 80f31829a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
var/spack/repos/builtin/packages/py-tensorflow/package.py
View File

@ -856,6 +856,8 @@ def post_configure_fixes(self):
filter_file("build:opt --host_copt=-march=native", "", ".tf_configure.bazelrc") filter_file("build:opt --host_copt=-march=native", "", ".tf_configure.bazelrc")
def build(self, spec, prefix): def build(self, spec, prefix):
# Bazel needs the directory to exist on install
mkdirp(python_platlib)
tmp_path = env["TEST_TMPDIR"] tmp_path = env["TEST_TMPDIR"]
# https://docs.bazel.build/versions/master/command-line-reference.html # https://docs.bazel.build/versions/master/command-line-reference.html

5
var/spack/repos/builtin/packages/python/package.py
View File

@ -1260,11 +1260,6 @@ def setup_dependent_package(self, module, dependent_spec):
module.python_platlib = join_path(dependent_spec.prefix, self.platlib) module.python_platlib = join_path(dependent_spec.prefix, self.platlib)
module.python_purelib = join_path(dependent_spec.prefix, self.purelib) module.python_purelib = join_path(dependent_spec.prefix, self.purelib)
# Make the site packages directory for extensions
if dependent_spec.package.is_extension:
mkdirp(module.python_platlib)
mkdirp(module.python_purelib)
def add_files_to_view(self, view, merge_map, skip_if_exists=True): def add_files_to_view(self, view, merge_map, skip_if_exists=True):
bin_dir = self.spec.prefix.bin if sys.platform != "win32" else self.spec.prefix bin_dir = self.spec.prefix.bin if sys.platform != "win32" else self.spec.prefix
for src, dst in merge_map.items(): for src, dst in merge_map.items():