zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

magma now extends CudaPackage class, taking care of the gcc conflicts (#14471)

Browse Source 
* magma now extends CudaPackage class, taking care of the gcc conflicts

* enforce +cuda; thus cuda is dependency via CudaPackage class

* add conflict

* use cuda_arch to set GPU_TARGET build option

* get rid of unnecessary constraint

* flake8

* impose cuda version dependency found empirically

* add variant description

* add conflict

Co-authored-by: Sinan81 <Sinan81@github>
Co-authored-by: Sinan81 <sbulut@3vgeomatics.com>
This commit is contained in:
Sinan 2020-03-27 13:28:54 -07:00 committed by GitHub
parent d909c6d89d
commit 829bfb5788
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
var/spack/repos/builtin/packages/magma/package.py
View File

@ -7,10 +7,10 @@
from spack import * from spack import *
class Magma(CMakePackage): class Magma(CMakePackage, CudaPackage):
"""The MAGMA project aims to develop a dense linear algebra library similar to """The MAGMA project aims to develop a dense linear algebra library similar
LAPACK but for heterogeneous/hybrid architectures, starting with current to LAPACK but for heterogeneous/hybrid architectures, starting with
"Multicore+GPU" systems. current "Multicore+GPU" systems.
""" """
homepage = "http://icl.cs.utk.edu/magma/" homepage = "http://icl.cs.utk.edu/magma/"
@ -28,13 +28,15 @@ class Magma(CMakePackage):
description='Enable Fortran bindings support') description='Enable Fortran bindings support')
variant('shared', default=True, variant('shared', default=True,
description='Enable shared library') description='Enable shared library')
variant('cuda', default=True, description='Build with CUDA')
depends_on('blas') depends_on('blas')
depends_on('lapack') depends_on('lapack')
depends_on('cuda') depends_on('cuda@8:', when='@2.5.1:') # See PR #14471
conflicts('%gcc@6:', when='^cuda@:8') conflicts('~cuda', msg='Magma requires cuda')
conflicts('%gcc@7:', when='^cuda@:9') conflicts('cuda_arch=none',
msg='Please indicate a CUDA arch value or values')
patch('ibm-xl.patch', when='@2.2:2.5.0%xl') patch('ibm-xl.patch', when='@2.2:2.5.0%xl')
patch('ibm-xl.patch', when='@2.2:2.5.0%xl_r') patch('ibm-xl.patch', when='@2.2:2.5.0%xl_r')
@ -69,11 +71,14 @@ def cmake_args(self):
'-DCMAKE_Fortran_COMPILER=%s' % self.compiler.f77 '-DCMAKE_Fortran_COMPILER=%s' % self.compiler.f77
]) ])
if spec.satisfies('^cuda@9.0:'): if spec.satisfies('^cuda'):
cuda_arch = self.spec.variants['cuda_arch'].value
if '@:2.2.0' in spec: if '@:2.2.0' in spec:
options.extend(['-DGPU_TARGET=sm30']) capabilities = ' '.join('sm{0}'.format(i) for i in cuda_arch)
options.extend(['-DGPU_TARGET=' + capabilities])
else: else:
options.extend(['-DGPU_TARGET=sm_30']) capabilities = ' '.join('sm_{0}'.format(i) for i in cuda_arch)
options.extend(['-DGPU_TARGET=' + capabilities])
if '@2.5.0' in spec: if '@2.5.0' in spec:
options.extend(['-DMAGMA_SPARSE=OFF']) options.extend(['-DMAGMA_SPARSE=OFF'])