zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increase min version for sparse_checkout (#45818)

Browse Source 
* Increase min version for sparse_checkout

* Update git_fetch.py

* style
This commit is contained in:
psakievich 2024-08-20 07:04:23 -06:00 committed by GitHub
parent 2ae5596e92
commit 85905959dc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/spack/spack/fetch_strategy.py
View File

@ -930,7 +930,9 @@ def _sparse_clone_src(self, commit=None, branch=None, tag=None, **kwargs):
dest = self.stage.source_path dest = self.stage.source_path
git = self.git git = self.git
if self.git_version < spack.version.Version("2.25.0.0"): if self.git_version < spack.version.Version("2.26.0"):
# technically this should be supported for 2.25, but bumping for OS issues
# see https://github.com/spack/spack/issues/45771
# code paths exist where the package is not set. Assure some indentifier for the # code paths exist where the package is not set. Assure some indentifier for the
# package that was configured for sparse checkout exists in the error message # package that was configured for sparse checkout exists in the error message
identifier = str(self.url) identifier = str(self.url)

2
lib/spack/spack/test/git_fetch.py
View File

@ -415,7 +415,7 @@ def test_git_sparse_paths_partial_clone(
for p in sparse_paths: for p in sparse_paths:
assert os.path.isdir(p) assert os.path.isdir(p)
if git_version < Version("2.25.0.0"): if git_version < Version("2.26.0.0"):
# older versions of git should fall back to a full clone # older versions of git should fall back to a full clone
for p in omitted_paths: for p in omitted_paths:
assert os.path.isdir(p) assert os.path.isdir(p)