zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added a new target message to comply with newer versions of GNU Make (#9068)

Browse Source 
#fixes 9067

Unit tests were failing on a system with GNU Make v 4.1
This commit is contained in:
Massimiliano Culpo 2018-08-22 16:32:25 +02:00 committed by Adam J. Stewart
parent 2f6a6a45a9
commit 85f84aabed
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/spack/spack/package.py
View File

@ -1166,11 +1166,13 @@ def _has_make_target(self, target):
# #
# GNU Make: # GNU Make:
# make: *** No rule to make target `test'. Stop. # make: *** No rule to make target `test'. Stop.
# *** No rule to make target 'test'. Stop.
# #
# BSD Make: # BSD Make:
# make: don't know how to make test. Stop # make: don't know how to make test. Stop
missing_target_msgs = [ missing_target_msgs = [
"No rule to make target `{0}'. Stop.", "No rule to make target `{0}'. Stop.",
"No rule to make target '{0}'. Stop.",
"don't know how to make {0}. Stop", "don't know how to make {0}. Stop",
] ]

1
lib/spack/spack/test/build_systems.py
View File

@ -59,6 +59,7 @@ def test_affirmative_make_check(directory, config, mock_packages):
'directory', 'directory',
glob.iglob(os.path.join(DATA_PATH, 'make', 'negative', '*')) glob.iglob(os.path.join(DATA_PATH, 'make', 'negative', '*'))
) )
@pytest.mark.regression('9067')
def test_negative_make_check(directory, config, mock_packages): def test_negative_make_check(directory, config, mock_packages):
"""Tests that Spack correctly ignores false positives in a Makefile.""" """Tests that Spack correctly ignores false positives in a Makefile."""