From 875abbeb8810709e064d484752ba4122fa72c1bf Mon Sep 17 00:00:00 2001 From: Massimiliano Culpo Date: Tue, 12 Nov 2024 13:03:25 +0100 Subject: [PATCH] unit-tests: remove a few FIXMEs --- lib/spack/spack/test/spec_semantics.py | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/spack/spack/test/spec_semantics.py b/lib/spack/spack/test/spec_semantics.py index 98d5abe158b..7472828bb7b 100644 --- a/lib/spack/spack/test/spec_semantics.py +++ b/lib/spack/spack/test/spec_semantics.py @@ -858,21 +858,18 @@ def test_spec_formatting(self, default_mock_concretization): package_segments = [ ("{NAME}", "", "name", lambda spec: spec), ("{VERSION}", "", "version", lambda spec: spec), - # FIXME (compiler as nodes): recover this semantic - # ("{compiler}", "", "compiler", lambda spec: spec), + ("{compiler}", "", "compiler", lambda spec: spec), ("{compiler_flags}", "", "compiler_flags", lambda spec: spec), ("{variants}", "", "variants", lambda spec: spec), ("{architecture}", "", "architecture", lambda spec: spec), ("{@VERSIONS}", "@", "versions", lambda spec: spec), - # FIXME (compiler as nodes): recover this semantic - # ("{%compiler}", "%", "compiler", lambda spec: spec), + ("{%compiler}", "%", "compiler", lambda spec: spec), ("{arch=architecture}", "arch=", "architecture", lambda spec: spec), ("{namespace=namespace}", "namespace=", "namespace", lambda spec: spec), - # FIXME (compiler as nodes): recover this semantic - # ("{compiler.name}", "", "name", lambda spec: spec.compiler), - # ("{compiler.version}", "", "version", lambda spec: spec.compiler), - # ("{%compiler.name}", "%", "name", lambda spec: spec.compiler), - # ("{@compiler.version}", "@", "version", lambda spec: spec.compiler), + ("{compiler.name}", "", "name", lambda spec: spec.compiler), + ("{compiler.version}", "", "version", lambda spec: spec.compiler), + ("{%compiler.name}", "%", "name", lambda spec: spec.compiler), + ("{@compiler.version}", "@", "version", lambda spec: spec.compiler), ("{architecture.platform}", "", "platform", lambda spec: spec.architecture), ("{architecture.os}", "", "os", lambda spec: spec.architecture), ("{architecture.target}", "", "target", lambda spec: spec.architecture),