From 8ac826cca892f9060ced53a071e78e0119dd8aca Mon Sep 17 00:00:00 2001 From: Richard Berger Date: Mon, 24 Mar 2025 14:58:47 -0600 Subject: [PATCH] hip: add missing HIPCC_LINK_FLAGS_APPEND (#49436) * hip: add missing HIPCC_LINK_FLAGS_APPEND --------- Co-authored-by: rbberger --- var/spack/repos/builtin/packages/hip/package.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/var/spack/repos/builtin/packages/hip/package.py b/var/spack/repos/builtin/packages/hip/package.py index 57e1e80d0c0..b32ae3e2e62 100644 --- a/var/spack/repos/builtin/packages/hip/package.py +++ b/var/spack/repos/builtin/packages/hip/package.py @@ -499,9 +499,10 @@ def set_variables(self, env): # bin/.hipVersion file can still be parsed. # See also https://github.com/ROCm/HIP/issues/2223 env.append_path( - "HIPCC_COMPILE_FLAGS_APPEND", - "--rocm-path={0}".format(paths["rocm-path"]), - separator=" ", + "HIPCC_COMPILE_FLAGS_APPEND", f"--rocm-path={paths['rocm-path']}", separator=" " + ) + env.append_path( + "HIPCC_LINK_FLAGS_APPEND", f"--rocm-path={paths['rocm-path']}", separator=" " ) elif self.spec.satisfies("+cuda"): env.set("CUDA_PATH", self.spec["cuda"].prefix) @@ -518,6 +519,9 @@ def set_variables(self, env): f"--gcc-toolchain={self.compiler.prefix}", separator=" ", ) + env.append_path( + "HIPCC_LINK_FLAGS_APPEND", f"--gcc-toolchain={self.compiler.prefix}", separator=" " + ) # This is picked up by CMake when using HIP as a CMake language. env.append_path("HIPFLAGS", f"--gcc-toolchain={self.compiler.prefix}", separator=" ")