zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

doxygen: Fix libiconv checks (#14106)

Browse Source 
PR #10589 introduced a libiconv dependency to doxygen. This causes
problems on Linux systems, since the iconv symbols are included in libc,
which causes CMake to use the external header but not the external
library. Work around this by always using the external libiconv.
This commit is contained in:
Michael Kuhn 2019-12-11 19:22:59 +01:00 committed by Adam J. Stewart
parent f2979da2af
commit 927f496306
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
var/spack/repos/builtin/packages/doxygen/package.py
View File

@ -43,3 +43,13 @@ class Doxygen(CMakePackage):
# https://github.com/Sleepyowl/doxygen/commit/6c380ba91ae41c6d5c409a5163119318932ae2a3?diff=unified
# Also - https://github.com/doxygen/doxygen/pull/6588
patch('shared_ptr.patch', when='@1.8.14')
def patch(self):
# On Linux systems, iconv is provided by libc. Since CMake finds the
# symbol in libc, it does not look for libiconv, which leads to linker
# errors. This makes sure that CMake always looks for the external
# libconv instead.
filter_file('check_function_exists(iconv_open ICONV_IN_GLIBC)',
'set(ICONV_IN_GLIBC FALSE)',
join_path('cmake', 'FindIconv.cmake'),
string=True)