zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

zziplib: support multiple build systems (#37058)

Browse Source 
This PR rewrites the zziplib recipe to use Spack's multiple build system
support.
This commit is contained in:
Glenn Johnson 2023-04-21 04:58:00 -05:00 committed by GitHub
parent 57b56499b2
commit 950079845c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
var/spack/repos/builtin/packages/zziplib/package.py
View File

@ -3,10 +3,12 @@
# #
# SPDX-License-Identifier: (Apache-2.0 OR MIT) # SPDX-License-Identifier: (Apache-2.0 OR MIT)
import spack.build_systems.autotools
import spack.build_systems.cmake
from spack.package import * from spack.package import *
class Zziplib(AutotoolsPackage): class Zziplib(AutotoolsPackage, CMakePackage):
"""The zziplib provides read access to zipped files in a zip-archive, using """The zziplib provides read access to zipped files in a zip-archive, using
compression based solely on free algorithms provided by zlib. It also compression based solely on free algorithms provided by zlib. It also
provides a functionality to overlay the archive filesystem with the provides a functionality to overlay the archive filesystem with the
@ -15,51 +17,27 @@ class Zziplib(AutotoolsPackage):
homepage = "https://github.com/gdraheim/zziplib" homepage = "https://github.com/gdraheim/zziplib"
url = "https://github.com/gdraheim/zziplib/archive/v0.13.69.tar.gz" url = "https://github.com/gdraheim/zziplib/archive/v0.13.69.tar.gz"
# Switch to CMake from 0.13.70, first working release is 0.13.71
version("0.13.72", sha256="93ef44bf1f1ea24fc66080426a469df82fa631d13ca3b2e4abaeab89538518dc") version("0.13.72", sha256="93ef44bf1f1ea24fc66080426a469df82fa631d13ca3b2e4abaeab89538518dc")
version("0.13.69", sha256="846246d7cdeee405d8d21e2922c6e97f55f24ecbe3b6dcf5778073a88f120544") version("0.13.69", sha256="846246d7cdeee405d8d21e2922c6e97f55f24ecbe3b6dcf5778073a88f120544")
patch("python2to3.patch", when="@:0.13.69") patch("python2to3.patch", when="@:0.13.69")
build_directory = "spack-build" # Switch to CMake from 0.13.70, first working release is 0.13.71
build_system(
conditional("cmake", when="@0.13.72:"),
conditional("autotools", when="@:0.13.69"),
default="cmake",
)
depends_on("python@3.5:", type="build", when="@0.13.71:") depends_on("python@3.5:", type="build", when="@0.13.72:")
depends_on("cmake", type="build", when="@0.13.71:")
depends_on("python", type="build") depends_on("python", type="build")
depends_on("zlib") depends_on("zlib")
# see zzip/CMakeLists.txt # see zzip/CMakeLists.txt
depends_on("coreutils", type="build", when="@0.13.71:") depends_on("coreutils", type="build", when="@0.13.72:")
depends_on("pkgconfig", type="build", when="@0.13.71:") depends_on("pkgconfig", type="build", when="@0.13.72:")
depends_on("zip", type="build", when="@0.13.71:") depends_on("zip", type="build", when="@0.13.72:")
depends_on("unzip", type="build", when="@0.13.71:") depends_on("unzip", type="build", when="@0.13.72:")
@when("@0.13.71:")
def autoreconf(self, spec, prefix):
touch("configure")
@when("@0.13.71:") class AutotoolsBuilder(spack.build_systems.autotools.AutotoolsBuilder):
def _cmake_args(self): build_directory = "spack-build"
spec = self.spec
args = []
zlib = spec["zlib"]
# Do not use self.define('VAR', path) unless a CMakePackage
args.extend(
[
"-DZLIB_LIBRARY:FILEPATH={0}".format(zlib.libs[0]),
"-DZLIB_INCLUDE_DIR:FILEPATH={0}".format(zlib.headers.directories[0]),
]
)
args.append("-DPYTHON_EXECUTABLE:FILEPATH={0}".format(spec["python"].command.path))
args.append("-DCMAKE_INSTALL_PREFIX:PATH={0}".format(spec.prefix))
return args
def configure_args(self):
args = ["--with-zlib={0}".format(self.spec["zlib"].prefix)]
return args
@when("@0.13.71:")
def configure(self, spec, prefix):
with working_dir("spack-build", create=True):
cmake_args = self._cmake_args()
cmake("..", *cmake_args)