zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/spec_semantics.py: split a test into multiple ones, test only necessary bits (#49806)

Browse Source
This commit is contained in:
Harmen Stoppels 2025-03-31 19:08:36 +02:00 committed by GitHub
parent 0f64f1baec
commit 95927df455
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
lib/spack/spack/test/spec_semantics.py
View File

@ -626,43 +626,31 @@ def test_propagate_reserved_variant_names(self, spec_string):
with pytest.raises(spack.spec_parser.SpecParsingError, match="Propagation"): with pytest.raises(spack.spec_parser.SpecParsingError, match="Propagation"):
Spec(spec_string) Spec(spec_string)
def test_unsatisfiable_multi_value_variant(self, default_mock_concretization): def test_multivalued_variant_1(self, default_mock_concretization):
# Semantics for a multi-valued variant is different # Semantics for a multi-valued variant is different
# Depending on whether the spec is concrete or not # Depending on whether the spec is concrete or not
a = default_mock_concretization('multivalue-variant foo="bar"') a = default_mock_concretization("multivalue-variant foo=bar")
spec_str = 'multivalue-variant foo="bar,baz"' b = Spec("multivalue-variant foo=bar,baz")
b = Spec(spec_str)
assert not a.satisfies(b) assert not a.satisfies(b)
assert not a.satisfies(spec_str)
# A concrete spec cannot be constrained further
with pytest.raises(UnsatisfiableSpecError):
a.constrain(b)
a = Spec('multivalue-variant foo="bar"') def test_multivalued_variant_2(self, default_mock_concretization):
spec_str = 'multivalue-variant foo="bar,baz"' a = Spec("multivalue-variant foo=bar")
b = Spec(spec_str) b = Spec("multivalue-variant foo=bar,baz")
# The specs are abstract and they **could** be constrained # The specs are abstract and they **could** be constrained
assert a.satisfies(b) assert a.satisfies(b)
assert a.satisfies(spec_str)
# An abstract spec can instead be constrained # An abstract spec can instead be constrained
assert a.constrain(b) assert a.constrain(b)
a = default_mock_concretization('multivalue-variant foo="bar,baz"') a = default_mock_concretization("multivalue-variant foo=bar,baz")
spec_str = 'multivalue-variant foo="bar,baz,quux"' b = Spec("multivalue-variant foo=bar,baz,quux")
b = Spec(spec_str)
assert not a.satisfies(b) assert not a.satisfies(b)
assert not a.satisfies(spec_str)
# A concrete spec cannot be constrained further
with pytest.raises(UnsatisfiableSpecError):
a.constrain(b)
a = Spec('multivalue-variant foo="bar,baz"') def test_multivalued_variant_3(self, default_mock_concretization):
spec_str = 'multivalue-variant foo="bar,baz,quux"' a = Spec("multivalue-variant foo=bar,baz")
b = Spec(spec_str) b = Spec("multivalue-variant foo=bar,baz,quux")
# The specs are abstract and they **could** be constrained # The specs are abstract and they **could** be constrained
assert a.intersects(b) assert a.intersects(b)
assert a.intersects(spec_str)
# An abstract spec can instead be constrained # An abstract spec can instead be constrained
assert a.constrain(b) assert a.constrain(b)
# ...but will fail during concretization if there are # ...but will fail during concretization if there are
@ -670,15 +658,14 @@ def test_unsatisfiable_multi_value_variant(self, default_mock_concretization):
with pytest.raises(InvalidVariantValueError): with pytest.raises(InvalidVariantValueError):
spack.concretize.concretize_one(a) spack.concretize.concretize_one(a)
def test_multivalued_variant_4(self, default_mock_concretization):
# This time we'll try to set a single-valued variant # This time we'll try to set a single-valued variant
a = Spec('multivalue-variant fee="bar"') a = Spec("multivalue-variant fee=bar")
spec_str = 'multivalue-variant fee="baz"' b = Spec("multivalue-variant fee=baz")
b = Spec(spec_str)
# The specs are abstract and they **could** be constrained, # The specs are abstract and they **could** be constrained,
# as before concretization I don't know which type of variant # as before concretization I don't know which type of variant
# I have (if it is not a BV) # I have (if it is not a BV)
assert a.intersects(b) assert a.intersects(b)
assert a.intersects(spec_str)
# A variant cannot be parsed as single-valued until we try to # A variant cannot be parsed as single-valued until we try to
# concretize. This means that we can constrain the variant above # concretize. This means that we can constrain the variant above
assert a.constrain(b) assert a.constrain(b)