From 9c1c5c29363f1662d2b780451066e6ad9e866368 Mon Sep 17 00:00:00 2001
From: simon-Leary42 <90859533+simon-Leary42@users.noreply.github.com>
Date: Tue, 21 Feb 2023 07:50:56 -0500
Subject: [PATCH] nonexistent module concise error message (#35502)

---
 lib/spack/spack/modules/common.py | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/lib/spack/spack/modules/common.py b/lib/spack/spack/modules/common.py
index eaf79f6d048..f5de9873d71 100644
--- a/lib/spack/spack/modules/common.py
+++ b/lib/spack/spack/modules/common.py
@@ -34,7 +34,7 @@
 import inspect
 import os.path
 import re
-from typing import Optional  # novm
+from typing import Optional  # novm # noqa: F401
 
 import llnl.util.filesystem
 import llnl.util.tty as tty
@@ -402,13 +402,19 @@ def get_module(module_type, spec, get_full_path, module_set_name="default", requ
     else:
         writer = spack.modules.module_types[module_type](spec, module_set_name)
         if not os.path.isfile(writer.layout.filename):
+            fmt_str = "{name}{@version}{/hash:7}"
             if not writer.conf.excluded:
-                err_msg = "No module available for package {0} at {1}".format(
-                    spec, writer.layout.filename
+                raise ModuleNotFoundError(
+                    "The module for package {} should be at {}, but it does not exist".format(
+                        spec.format(fmt_str), writer.layout.filename
+                    )
                 )
-                raise ModuleNotFoundError(err_msg)
             elif required:
-                tty.debug("The module configuration has excluded {0}: " "omitting it".format(spec))
+                tty.debug(
+                    "The module configuration has excluded {}: omitting it".format(
+                        spec.format(fmt_str)
+                    )
+                )
             else:
                 return None