zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libfabric package: add kdreg variant (off by default) (#12521)

Browse Source 
This variant (off by default) adds support for the kdreg option in
the GNI provider. It is disabled by default in order to avoid
potential runtime conflicts with the cray-mpich library. Only one
library at a time can use this feature.

This patch allows the libfabric package to work correctly out of
the box on systems like Cori at NERSC (since it's CLE7 update).
Otherwise the spack build may autodetect kdreg headers on the system
and enable this problematic feature.
This commit is contained in:
Phil Carns 2019-08-22 20:02:57 -04:00 committed by Peter Scheibel
parent 21f2a1ef83
commit a707c5bd2b
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
var/spack/repos/builtin/packages/libfabric/package.py
View File

@ -48,6 +48,13 @@ class Libfabric(AutotoolsPackage):
multi=True multi=True
) )
# NOTE: the 'kdreg' variant enables use of the special /dev/kdreg file to
# assist in memory registration caching in the GNI provider. This
# device file can only be opened once per process, however, and thus it
# frequently conflicts with MPI.
variant('kdreg', default=False,
description='Enable kdreg on supported Cray platforms')
depends_on('rdma-core', when='fabrics=verbs') depends_on('rdma-core', when='fabrics=verbs')
depends_on('opa-psm2', when='fabrics=psm2') depends_on('opa-psm2', when='fabrics=psm2')
depends_on('psm', when='fabrics=psm') depends_on('psm', when='fabrics=psm')
@ -99,6 +106,11 @@ def autoreconf(self, spec, prefix):
def configure_args(self): def configure_args(self):
args = [] args = []
if '+kdreg' in self.spec:
args.append('--with-kdreg=yes')
else:
args.append('--with-kdreg=no')
for fabric in self.fabrics: for fabric in self.fabrics:
if 'fabrics=' + fabric in self.spec: if 'fabrics=' + fabric in self.spec:
args.append('--enable-{0}=yes'.format(fabric)) args.append('--enable-{0}=yes'.format(fabric))