From a998fa25b0337c67d7426bc13185c4bd04414ab4 Mon Sep 17 00:00:00 2001 From: psakievich Date: Tue, 11 Jun 2019 06:15:41 -0600 Subject: [PATCH] Paraview: Add motionfx Intel workaround (#11608) * Paraview/VTK: Fix failure on intel builds Paraview@5.6.0 fails to build with intel compilers on certain platforms. Error messages have been traced to the optional MotionFX lib. (see https://discourse.paraview.org/t/error-build-5-6-0-rc1/572) Turning off motionfx allows for succesful builds on these platforms. --- var/spack/repos/builtin/packages/paraview/package.py | 7 +++++++ var/spack/repos/builtin/packages/vtk/package.py | 4 ++++ 2 files changed, 11 insertions(+) diff --git a/var/spack/repos/builtin/packages/paraview/package.py b/var/spack/repos/builtin/packages/paraview/package.py index 2cef82eafa5..f49eec86a56 100644 --- a/var/spack/repos/builtin/packages/paraview/package.py +++ b/var/spack/repos/builtin/packages/paraview/package.py @@ -236,4 +236,11 @@ def nvariant_bool(feature): '-DGIT_EXECUTABLE=FALSE' ]) + # A bug that has been found in vtk causes an error for + # intel builds for version 5.6. This should be revisited + # with later versions of Paraview to see if the issues still + # arises. + if '%intel' in spec and spec.version >= Version('5.6'): + cmake_args.append('-DPARAVIEW_ENABLE_MOTIONFX:BOOL=OFF') + return cmake_args diff --git a/var/spack/repos/builtin/packages/vtk/package.py b/var/spack/repos/builtin/packages/vtk/package.py index 031bb210d05..3ce93c51250 100644 --- a/var/spack/repos/builtin/packages/vtk/package.py +++ b/var/spack/repos/builtin/packages/vtk/package.py @@ -253,4 +253,8 @@ def cmake_args(self): self.compiler.version >= Version('5.1.0')): cmake_args.extend(['-DVTK_REQUIRED_OBJCXX_FLAGS=""']) + # A bug in tao pegtl causes build failures with intel compilers + if '%intel' in spec and spec.version >= Version('8.2'): + cmake_args.append( + '-DVTK_MODULE_ENABLE_VTK_IOMotionFX:BOOL=OFF') return cmake_args