zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

magma: add package name to conflict messages (#38984)

Browse Source 
Without the package name being present in the conflict messages, it is
significantly more difficult to debug concretization failures in
environments that contain many packages.
This commit is contained in:
Aiden Grossman 2023-07-19 00:47:26 -07:00 committed by GitHub
parent 76b6436ade
commit a99eaa9541
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
var/spack/repos/builtin/packages/magma/package.py
View File

@ -48,10 +48,12 @@ class Magma(CMakePackage, CudaPackage, ROCmPackage):
depends_on("hipsparse", when="+rocm")
depends_on("python", when="@master", type="build")
conflicts("~cuda", when="~rocm", msg="Either CUDA or HIP support must be enabled")
conflicts("+rocm", when="+cuda", msg="CUDA must be disabled to support HIP (ROCm)")
conflicts("+rocm", when="@:2.5.4", msg="HIP support starts in version 2.6.0")
conflicts("cuda_arch=none", when="+cuda", msg="Please indicate a CUDA arch value or values")
conflicts("~cuda", when="~rocm", msg="magma: Either CUDA or HIP support must be enabled")
conflicts("+rocm", when="+cuda", msg="magma: CUDA must be disabled to support HIP (ROCm)")
conflicts("+rocm", when="@:2.5.4", msg="magma: HIP support starts in version 2.6.0")
conflicts(
"cuda_arch=none", when="+cuda", msg="magma: Please indicate a CUDA arch value or values"
)
# currently not compatible with CUDA-11
# https://bitbucket.org/icl/magma/issues/22/cuda-11-changes-issue
@ -63,11 +65,11 @@ class Magma(CMakePackage, CudaPackage, ROCmPackage):
conflicts("cuda_arch={}".format(target))
# Some cuda_arch values had support added recently
conflicts("cuda_arch=37", when="@:2.5")
conflicts("cuda_arch=60", when="@:2.2")
conflicts("cuda_arch=70", when="@:2.2")
conflicts("cuda_arch=75", when="@:2.5.0")
conflicts("cuda_arch=80", when="@:2.5.3")
conflicts("cuda_arch=37", when="@:2.5", msg="magma: cuda_arch=37 needs a version > 2.5")
conflicts("cuda_arch=60", when="@:2.2", msg="magma: cuda_arch=60 needs a version > 2.2")
conflicts("cuda_arch=70", when="@:2.2", msg="magma: cuda_arch=70 needs a version > 2.2")
conflicts("cuda_arch=75", when="@:2.5.0", msg="magma: cuda_arch=75 needs a version > 2.5.0")
conflicts("cuda_arch=80", when="@:2.5.3", msg="magma: cuda_arch=80 needs a version > 2.5.3")
patch("ibm-xl.patch", when="@2.2:2.5.0%xl")
patch("ibm-xl.patch", when="@2.2:2.5.0%xl_r")