Bugfix/config caching 13754 (#13759)

* remove reference to `spack.store` in method definition

Referencing `spack.store` in method definition will cache the `spack.config.config` singleton variable too early, before we have a chance to add command line and environment scopes.
This commit is contained in:
Greg Becker 2019-11-15 13:55:51 -08:00 committed by GitHub
parent 46bfcbbd3d
commit aa83c483f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -637,8 +637,7 @@ def is_relocatable(spec):
return True
def file_is_relocatable(
file, paths_to_relocate=[spack.store.layout.root, spack.paths.prefix]):
def file_is_relocatable(file, paths_to_relocate=None):
"""Returns True if the file passed as argument is relocatable.
Args:
@ -651,6 +650,8 @@ def file_is_relocatable(
ValueError: if the file does not exist or the path is not absolute
"""
default_paths_to_relocate = [spack.store.layout.root, spack.paths.prefix]
paths_to_relocate = paths_to_relocate or default_paths_to_relocate
if not (platform.system().lower() == 'darwin'
or platform.system().lower() == 'linux'):