zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mvapich2: Add patch to avoid segmentation fault in MPIR_Attr_delete_list (#39058)

Browse Source
This commit is contained in:
Mosè Giordano 2023-07-23 05:44:15 +01:00 committed by GitHub
parent cc2fa9895e
commit ac3c0a4347
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
var/spack/repos/builtin/packages/mvapich2/mpir_attr_delete_list_segfault.patch Normal file
View File

@ -0,0 +1,18 @@
--- a/src/mpi/attr/attrutil.c
+++ b/src/mpi/attr/attrutil.c
@@ -266,6 +266,7 @@
corresponding keyval */
/* Still to do: capture any error returns but continue to
process attributes */
+ if (p->keyval) {
mpi_errno = MPIR_Call_attr_delete( handle, p );
/* We must also remove the keyval reference. If the keyval
@@ -282,6 +283,7 @@
MPIU_Handle_obj_free( &MPID_Keyval_mem, p->keyval );
}
}
+ }
MPIU_Handle_obj_free( &MPID_Attr_mem, p );

4
var/spack/repos/builtin/packages/mvapich2/package.py
View File

@ -133,6 +133,10 @@ class Mvapich2(AutotoolsPackage):
depends_on("libfabric", when="fabrics=nemesisofi") depends_on("libfabric", when="fabrics=nemesisofi")
depends_on("slurm", when="process_managers=slurm") depends_on("slurm", when="process_managers=slurm")
# Fix segmentation fault in `MPIR_Attr_delete_list`:
# <https://lists.osu.edu/pipermail/mvapich-discuss/2023-January/010695.html>.
patch("mpir_attr_delete_list_segfault.patch", when="@2.3.7")
conflicts("fabrics=psm2", when="@:2.1") # psm2 support was added at version 2.2 conflicts("fabrics=psm2", when="@:2.1") # psm2 support was added at version 2.2
filter_compiler_wrappers("mpicc", "mpicxx", "mpif77", "mpif90", "mpifort", relative_root="bin") filter_compiler_wrappers("mpicc", "mpicxx", "mpif77", "mpif90", "mpifort", relative_root="bin")