zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

superlu: simplify cmake logic and fix cuda conflict (#28658)

Browse Source 
* superlu-dist: use CMakePackage helper functions

* Fix #28609

It's OK to have CUDA in the dependency tree as long as it's not being
used for superlu-cuda.
This commit is contained in:
Seth R. Johnson 2022-01-29 13:58:09 +01:00 committed by GitHub
parent a98a261b74
commit aece700e14
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 44 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
var/spack/repos/builtin/packages/superlu-dist/package.py
View File

@ -54,7 +54,8 @@ class SuperluDist(CMakePackage, CudaPackage, ROCmPackage):
conflicts('+rocm', when='+cuda')
conflicts('+cuda', when='@:6.3')
conflicts('^cuda@11.5.0:', when='@7.1.0:')
# See https://github.com/xiaoyeli/superlu_dist/issues/87
conflicts('^cuda@11.5.0:', when='@7.1.0:7.1 +cuda')
patch('xl-611.patch', when='@:6.1.1 %xl')
patch('xl-611.patch', when='@:6.1.1 %xl_r')
@ -63,59 +64,60 @@ class SuperluDist(CMakePackage, CudaPackage, ROCmPackage):
def cmake_args(self):
spec = self.spec
args = [
'-DCMAKE_C_COMPILER=%s' % spec['mpi'].mpicc,
'-DCMAKE_CXX_COMPILER=%s' % spec['mpi'].mpicxx,
'-DCMAKE_INSTALL_LIBDIR:STRING=%s' % self.prefix.lib,
'-DCMAKE_INSTALL_BINDIR:STRING=%s' % self.prefix.bin,
'-DTPL_BLAS_LIBRARIES=%s' % spec['blas'].libs.joined(";"),
'-DTPL_LAPACK_LIBRARIES=%s' % spec['lapack'].libs.joined(";"),
'-DUSE_XSDK_DEFAULTS=YES',
'-DTPL_PARMETIS_LIBRARIES=%s' % spec['parmetis'].libs.ld_flags +
';' + spec['metis'].libs.ld_flags,
'-DTPL_PARMETIS_INCLUDE_DIRS=%s' %
spec['parmetis'].prefix.include +
';' + spec['metis'].prefix.include
]
cmake_args = []
if (spec.satisfies('%xl') or spec.satisfies('%xl_r')) and \
spec.satisfies('@:6.1.1'):
args.append('-DCMAKE_C_FLAGS=-DNoChange')
def append_define(*args):
cmake_args.append(CMakePackage.define(*args))
if '+int64' in spec:
args.append('-DXSDK_INDEX_SIZE=64')
else:
args.append('-DXSDK_INDEX_SIZE=32')
def append_from_variant(*args):
cmake_args.append(self.define_from_variant(*args))
if '+openmp' in spec:
args.append('-Denable_openmp=ON')
else:
args.append('-Denable_openmp=OFF')
args.append('-DCMAKE_DISABLE_FIND_PACKAGE_OpenMP=ON')
append_define('CMAKE_C_COMPILER', spec['mpi'].mpicc)
append_define('CMAKE_CXX_COMPILER', spec['mpi'].mpicxx)
append_define('CMAKE_INSTALL_LIBDIR:STRING', self.prefix.lib)
append_define('CMAKE_INSTALL_BINDIR:STRING', self.prefix.bin)
append_define('TPL_BLAS_LIBRARIES', spec['blas'].libs)
append_define('TPL_LAPACK_LIBRARIES', spec['lapack'].libs)
append_define('USE_XSDK_DEFAULTS', True)
append_define('TPL_PARMETIS_LIBRARIES', [
spec['parmetis'].libs.ld_flags,
spec['metis'].libs.ld_flags
])
append_define('TPL_PARMETIS_INCLUDE_DIRS', [
spec['parmetis'].prefix.include,
spec['metis'].prefix.include
])
if ((spec.satisfies('%xl') or spec.satisfies('%xl_r'))
and spec.satisfies('@:6.1.1')):
append_define('CMAKE_C_FLAGS', '-DNoChange')
append_define('XSDK_INDEX_SIZE', '64' if '+int64' in spec else '32')
append_from_variant('enable_openmp', 'openmp')
if '~openmp' in spec:
append_define('CMAKE_DISABLE_FIND_PACKAGE_OpenMP', True)
if '+cuda' in spec:
args.append('-DTPL_ENABLE_CUDALIB=TRUE')
args.append('-DTPL_CUDA_LIBRARIES=-L%s -lcublas -lcudart'
% spec['cuda'].libs.directories[0])
append_define('TPL_ENABLE_CUDALIB', True)
append_define(
'TPL_CUDA_LIBRARIES',
'-L%s -lcublas -lcudart' % spec['cuda'].libs.directories[0]
)
cuda_arch = spec.variants['cuda_arch'].value
if cuda_arch[0] != 'none':
args.append(
'-DCMAKE_CUDA_FLAGS=-arch=sm_{0}'.format(cuda_arch[0]))
append_define('CMAKE_CUDA_FLAGS', '-arch=sm_' + cuda_arch[0])
if '+rocm' in spec and spec.satisfies('@amd'):
args.append('-DTPL_ENABLE_HIPLIB=TRUE')
args.append(
'-DHIP_ROOT_DIR={0}'.format(spec['hip'].prefix))
append_define('TPL_ENABLE_HIPLIB', True)
append_define('HIP_ROOT_DIR', spec['hip'].prefix)
rocm_archs = spec.variants['amdgpu_target'].value
if 'none' not in rocm_archs:
args.append('-DHIP_HIPCC_FLAGS=--amdgpu-target={0}'.
format(",".join(rocm_archs)))
append_define('HIP_HIPCC_FLAGS',
'--amdgpu-target=' + ",".join(rocm_archs))
if '+shared' in spec:
args.append('-DBUILD_SHARED_LIBS:BOOL=ON')
else:
args.append('-DBUILD_SHARED_LIBS:BOOL=OFF')
return args
append_from_variant('BUILD_SHARED_LIBS', 'shared')
return cmake_args
def flag_handler(self, name, flags):
flags = list(flags)