zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Provide more info in SbangPathError to aid CI debugging (#26316)

Browse Source
This commit is contained in:
Tamara Dahlgren 2021-10-06 12:03:33 -07:00 committed by GitHub
parent cb5b28392e
commit affd2236e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/spack/spack/hooks/sbang.py
View File

@ -28,9 +28,12 @@ def sbang_install_path():
"""Location sbang should be installed within Spack's ``install_tree``.""" """Location sbang should be installed within Spack's ``install_tree``."""
sbang_root = str(spack.store.unpadded_root) sbang_root = str(spack.store.unpadded_root)
install_path = os.path.join(sbang_root, "bin", "sbang") install_path = os.path.join(sbang_root, "bin", "sbang")
if len(install_path) > shebang_limit: path_length = len(install_path)
raise SbangPathError( if path_length > shebang_limit:
'Install tree root is too long. Spack cannot patch shebang lines.') msg = ('Install tree root is too long. Spack cannot patch shebang lines'
' when script path length ({0}) exceeds limit ({1}).\n {2}')
msg = msg.format(path_length, shebang_limit, install_path)
raise SbangPathError(msg)
return install_path return install_path

18
lib/spack/spack/test/sbang.py
View File

@ -225,3 +225,21 @@ def test_install_sbang(install_mockery):
# install again and make sure sbang is still fine # install again and make sure sbang is still fine
sbang.install_sbang() sbang.install_sbang()
check_sbang_installation() check_sbang_installation()
def test_install_sbang_too_long(tmpdir):
root = str(tmpdir)
num_extend = sbang.shebang_limit - len(root) - len('/bin/sbang')
long_path = root
while num_extend > 1:
add = min(num_extend, 255)
long_path = os.path.join(long_path, 'e' * add)
num_extend -= add
with spack.store.use_store(spack.store.Store(long_path)):
with pytest.raises(sbang.SbangPathError) as exc_info:
sbang.sbang_install_path()
err = str(exc_info.value)
assert 'root is too long' in err
assert 'exceeds limit' in err
assert 'cannot patch' in err