Merge pull request #1169 from davydden/feature/install_argument_tests_petsc_fixes

--run-tests install argument and petsc fixes

lib/spack/spack/cmd/install.py

@@ -58,6 +58,10 @@ def setup_parser(subparser):
         help="Install a package *without* cleaning the environment.")
     subparser.add_argument(
         'packages', nargs=argparse.REMAINDER, help="specs of packages to install")
+    subparser.add_argument(
+        '--run-tests', action='store_true', dest='run_tests',
+        help="Run tests during installation of a package.")
+
 
 
 def install(parser, args):
@@ -80,6 +84,7 @@ def install(parser, args):
                 keep_stage=args.keep_stage,
                 ignore_deps=args.ignore_deps,
                 make_jobs=args.jobs,
+                run_tests=args.run_tests,
                 verbose=args.verbose,
                 fake=args.fake,
                 dirty=args.dirty,

lib/spack/spack/package.py

@@ -311,6 +311,8 @@ class SomePackage(Package):
     parallel = True
     """# jobs to use for parallel make. If set, overrides default of ncpus."""
     make_jobs = None
+    """By default do not run tests within package's install()"""
+    run_tests = False
     """Most packages are NOT extendable. Set to True if you want extensions."""
     extendable = False
     """List of prefix-relative file paths (or a single path). If these do
@@ -881,6 +883,7 @@ def do_install(self,
                    skip_patch=False,
                    verbose=False,
                    make_jobs=None,
+                   run_tests=False,
                    fake=False,
                    explicit=False,
                    dirty=False,
@@ -902,6 +905,7 @@ def do_install(self,
         verbose     -- Display verbose build output (by default, suppresses it)
         dirty       -- Don't clean the build environment before installing.
         make_jobs   -- Number of make jobs to use for install. Default is ncpus
+        run_tests   -- Runn tests within the package's install()
         """
         if not self.spec.concrete:
             raise ValueError("Can only install concrete packages.")
@@ -932,7 +936,11 @@ def do_install(self,
                                          fake=fake,
                                          skip_patch=skip_patch,
                                          verbose=verbose,
-                                         make_jobs=make_jobs)
+                                         make_jobs=make_jobs,
+                                         run_tests=run_tests)
+
+        # Set run_tests flag before starting build.
+        self.run_tests = run_tests
 
         # Set parallelism before starting build.
         self.make_jobs = make_jobs