zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gitlab: when_possible -> false (#33443)

Browse Source 
`reuse` and `when_possible` concretization broke the invariant that
`spec[pkg_name]` has unique keys. This invariant is relied on in tons of
places, such as when setting up the build environment.

When using `when_possible` concretization, one may end up with two or
more `perl`s or `python`s among the transitive deps of a spec, because
concretization does not consider build-only deps of reusable specs.

Until the code base is fixed not to rely on this broken property of
`__getitem__`, we should disable reuse in CI.
This commit is contained in:
Harmen Stoppels 2022-10-21 14:42:06 +02:00 committed by GitHub
parent 93db654b8d
commit b1559cc831
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml
View File

@ -3,7 +3,7 @@ spack:
concretizer: concretizer:
reuse: false reuse: false
unify: when_possible unify: false
config: config:
install_tree: install_tree:

2
share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml
View File

@ -3,7 +3,7 @@ spack:
concretizer: concretizer:
reuse: false reuse: false
unify: when_possible unify: false
config: config:
concretizer: clingo concretizer: clingo