zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use python platform.system for system ID (#1499)

Browse Source 
* Rebase and merging using platform.system

Rebasing and merging using platform.system instead of uname -a.

* Add missing import platform statement

* Remove subprocess import

Remove ununsed import subprocess to make changes flak8 compliant
This commit is contained in:
Mario Melara 2016-10-11 07:04:29 -07:00 committed by Todd Gamblin
parent 4d939802ae
commit b42dbc01fe
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/spack/spack/platforms/darwin.py
View File

@ -1,4 +1,4 @@
import subprocess import platform
from spack.architecture import Platform, Target from spack.architecture import Platform, Target
from spack.operating_systems.mac_os import MacOs from spack.operating_systems.mac_os import MacOs
@ -22,6 +22,4 @@ def __init__(self):
@classmethod @classmethod
def detect(self): def detect(self):
platform = subprocess.Popen(['uname', '-a'], stdout=subprocess.PIPE) return 'darwin' in platform.system().lower()
platform, _ = platform.communicate()
return 'darwin' in platform.strip().lower()

5
lib/spack/spack/platforms/linux.py
View File

@ -1,4 +1,3 @@
import subprocess
import platform import platform
from spack.architecture import Platform, Target from spack.architecture import Platform, Target
from spack.operating_systems.linux_distro import LinuxDistro from spack.operating_systems.linux_distro import LinuxDistro
@ -27,6 +26,4 @@ def __init__(self):
@classmethod @classmethod
def detect(self): def detect(self):
platform = subprocess.Popen(['uname', '-a'], stdout=subprocess.PIPE) return 'linux' in platform.system().lower()
platform, _ = platform.communicate()
return 'linux' in platform.strip().lower()