zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

binary_distribution: compress level 9 -> 6 (#33513)

Browse Source 
Use the same compression level as `gzip` (6) instead of what Python uses
(9).

The LLVM tarball takes 4m instead of 12m to create, and is <1% larger.
That's not worth the wait...
This commit is contained in:
Harmen Stoppels
2022-10-26 00:15:16 +02:00
committed by GitHub
parent 8aa9758024
commit b538acb2a9
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/spack/spack/binary_distribution.py
View File

@@ -1161,7 +1161,11 @@ def _build_tarball(
tty.die(e) tty.die(e)
# create gzip compressed tarball of the install prefix # create gzip compressed tarball of the install prefix
with closing(tarfile.open(tarfile_path, "w:gz")) as tar: # On AMD Ryzen 3700X and an SSD disk, we have the following on compression speed:
# compresslevel=6 gzip default: llvm takes 4mins, roughly 2.1GB
# compresslevel=9 python default: llvm takes 12mins, roughly 2.1GB
# So we follow gzip.
with closing(tarfile.open(tarfile_path, "w:gz", compresslevel=6)) as tar:
tar.add(name="%s" % workdir, arcname="%s" % os.path.basename(spec.prefix)) tar.add(name="%s" % workdir, arcname="%s" % os.path.basename(spec.prefix))
# remove copy of install directory # remove copy of install directory
shutil.rmtree(workdir) shutil.rmtree(workdir)