zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mpich: Add ROCm variant (#30502)

Browse Source 
* mpich: Add ROCm variant

* fixup
This commit is contained in:
Ken Raffenetti 2022-05-05 16:49:41 -05:00 committed by GitHub
parent e6d1c2d9f3
commit b6e1cbd86d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
var/spack/repos/builtin/packages/mpich/package.py
View File

@ -10,7 +10,7 @@
from spack import * from spack import *
class Mpich(AutotoolsPackage, CudaPackage): class Mpich(AutotoolsPackage, CudaPackage, ROCmPackage):
"""MPICH is a high performance and widely portable implementation of """MPICH is a high performance and widely portable implementation of
the Message Passing Interface (MPI) standard.""" the Message Passing Interface (MPI) standard."""
@ -112,12 +112,16 @@ class Mpich(AutotoolsPackage, CudaPackage):
depends_on('yaksa', when='@4.0: device=ch4 datatype-engine=auto') depends_on('yaksa', when='@4.0: device=ch4 datatype-engine=auto')
depends_on('yaksa', when='@4.0: device=ch4 datatype-engine=yaksa') depends_on('yaksa', when='@4.0: device=ch4 datatype-engine=yaksa')
depends_on('yaksa+cuda', when='+cuda ^yaksa') depends_on('yaksa+cuda', when='+cuda ^yaksa')
depends_on('yaksa+rocm', when='+rocm ^yaksa')
conflicts('datatype-engine=yaksa', when='device=ch3') conflicts('datatype-engine=yaksa', when='device=ch3')
# Todo: cuda can be a conditional variant, but it does not seem to work when # Todo: cuda can be a conditional variant, but it does not seem to work when
# overriding the variant from CudaPackage. # overriding the variant from CudaPackage.
conflicts('+cuda', when='@:3.3') conflicts('+cuda', when='@:3.3')
conflicts('+cuda', when='device=ch3') conflicts('+cuda', when='device=ch3')
conflicts('+rocm', when='@:4.0')
conflicts('+rocm', when='device=ch3')
conflicts('+cuda', when='+rocm', msg='CUDA must be disabled to support ROCm')
provides('mpi@:4.0') provides('mpi@:4.0')
provides('mpi@:3.1', when='@:3.2') provides('mpi@:3.1', when='@:3.2')
@ -497,6 +501,11 @@ def configure_args(self):
config_args += self.with_or_without('cuda', activation_value='prefix') config_args += self.with_or_without('cuda', activation_value='prefix')
if '+rocm' in spec:
config_args.append('--with-hip={0}'.format(spec['hip'].prefix))
else:
config_args.append('--without-hip')
# setup device configuration # setup device configuration
device_config = '' device_config = ''
if 'device=ch4' in spec: if 'device=ch4' in spec: