zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ignored config:install_missing_compilers from unit tests (#47357)

Browse Source
This commit is contained in:
Tamara Dahlgren 2024-11-02 01:36:05 -07:00 committed by GitHub
parent 133895e785
commit b8461f3d2d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
lib/spack/spack/test/installer.py
View File

@ -644,13 +644,12 @@ def test_prepare_for_install_on_installed(install_mockery, monkeypatch):
def test_installer_init_requests(install_mockery): def test_installer_init_requests(install_mockery):
"""Test of installer initial requests.""" """Test of installer initial requests."""
spec_name = "dependent-install" spec_name = "dependent-install"
with spack.config.override("config:install_missing_compilers", True): installer = create_installer([spec_name], {})
installer = create_installer([spec_name], {})
# There is only one explicit request in this case # There is only one explicit request in this case
assert len(installer.build_requests) == 1 assert len(installer.build_requests) == 1
request = installer.build_requests[0] request = installer.build_requests[0]
assert request.pkg.name == spec_name assert request.pkg.name == spec_name
@pytest.mark.parametrize("transitive", [True, False]) @pytest.mark.parametrize("transitive", [True, False])
@ -743,21 +742,20 @@ def _missing(*args, **kwargs):
# Set the configuration to ensure _requeue_with_build_spec_tasks actually # Set the configuration to ensure _requeue_with_build_spec_tasks actually
# does something. # does something.
with spack.config.override("config:install_missing_compilers", True): installer = create_installer(["depb"], {})
installer = create_installer(["depb"], {}) installer._init_queue()
installer._init_queue() request = installer.build_requests[0]
request = installer.build_requests[0] task = create_build_task(request.pkg)
task = create_build_task(request.pkg)
# Drop one of the specs so its task is missing before _install_task # Drop one of the specs so its task is missing before _install_task
popped_task = installer._pop_task() popped_task = installer._pop_task()
assert inst.package_id(popped_task.pkg.spec) not in installer.build_tasks assert inst.package_id(popped_task.pkg.spec) not in installer.build_tasks
monkeypatch.setattr(task, "execute", _missing) monkeypatch.setattr(task, "execute", _missing)
installer._install_task(task, None) installer._install_task(task, None)
# Ensure the dropped task/spec was added back by _install_task # Ensure the dropped task/spec was added back by _install_task
assert inst.package_id(popped_task.pkg.spec) in installer.build_tasks assert inst.package_id(popped_task.pkg.spec) in installer.build_tasks
def test_release_lock_write_n_exception(install_mockery, tmpdir, capsys): def test_release_lock_write_n_exception(install_mockery, tmpdir, capsys):