zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

install_test: first look at builder, then package (#47735)

Browse Source
This commit is contained in:
Harmen Stoppels 2024-11-25 11:53:28 +01:00 committed by GitHub
parent 406c73ae11
commit bf12bb57e7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/spack/spack/install_test.py
View File

@ -375,23 +375,16 @@ def phase_tests(self, builder, phase_name: str, method_names: List[str]):
for name in method_names: for name in method_names:
try: try:
# Prefer the method in the package over the builder's. fn = getattr(builder, name, None) or getattr(builder.pkg, name)
# We need this primarily to pick up arbitrarily named test
# methods but also some build-time checks.
fn = getattr(builder.pkg, name, getattr(builder, name))
msg = f"RUN-TESTS: {phase_name}-time tests [{name}]"
print_message(logger, msg, verbose)
fn()
except AttributeError as e: except AttributeError as e:
msg = f"RUN-TESTS: method not implemented [{name}]" print_message(logger, f"RUN-TESTS: method not implemented [{name}]", verbose)
print_message(logger, msg, verbose) self.add_failure(e, f"RUN-TESTS: method not implemented [{name}]")
self.add_failure(e, msg)
if fail_fast: if fail_fast:
break break
continue
print_message(logger, f"RUN-TESTS: {phase_name}-time tests [{name}]", verbose)
fn()
if have_tests: if have_tests:
print_message(logger, "Completed testing", verbose) print_message(logger, "Completed testing", verbose)