Move dpeendency environment setup to build_environemnt.

lib/spack/spack/build_environment.py

@@ -207,3 +207,8 @@ def setup_package(pkg):
     set_compiler_environment_variables(pkg)
     set_build_environment_variables(pkg)
     set_module_variables_for_package(pkg)
+
+    # Allow dependencies to set up environment as well.
+    for dep_spec in pkg.spec.traverse(root=False):
+        dep_spec.package.setup_dependent_environment(
+            pkg.module, dep_spec, pkg.spec)

lib/spack/spack/package.py

@@ -829,11 +829,6 @@ def do_install(self, **kwargs):
                 self.stage.chdir_to_source()
                 build_env.setup_package(self)
 
-                # Allow dependencies to further set up the environment.
-                for dep_spec in self.spec.traverse(root=False):
-                    dep_spec.package.setup_dependent_environment(
-                        self.module, dep_spec, self.spec)
-
                 if fake_install:
                     self.do_fake_install()
                 else: