zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gdk-pixbuf: only build tests when requested (#32452)

Browse Source 
The building of tests is optional [as of 2.42.9](801eef111d). This applies this option in the build.

The reason the option was added was to deal with test build failures in sandboxed environments and with certain glibc versions (caused by glib gresources). For example, with the latest version glibc and in the latest version of docker these tests [cannot be built](https://github.com/moby/moby/issues/43595).
This commit is contained in:
Wouter Deconinck 2022-08-31 18:16:22 -05:00 committed by GitHub
parent f1f831edef
commit c75c27c95c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
var/spack/repos/builtin/packages/gdk-pixbuf/package.py
View File

@ -91,6 +91,9 @@ def setup_dependent_run_environment(self, env, dependent_spec):
def install(self, spec, prefix): def install(self, spec, prefix):
with working_dir("spack-build", create=True): with working_dir("spack-build", create=True):
meson_args = std_meson_args + ["-Dman={0}".format("+man" in spec)] meson_args = std_meson_args + ["-Dman={0}".format("+man" in spec)]
# Only build tests when requested
if self.version >= Version("2.42.9"):
meson_args += ["-Dtests={0}".format(self.run_tests)]
# Based on suggestion by luigi-calori and the fixup shown by lee218llnl: # Based on suggestion by luigi-calori and the fixup shown by lee218llnl:
# https://github.com/spack/spack/pull/27254#issuecomment-974464174 # https://github.com/spack/spack/pull/27254#issuecomment-974464174
if "+x11" in spec: if "+x11" in spec: