Massive conversion from Package to CMakePackage (#4975)

var/spack/repos/builtin/packages/openscenegraph/package.py

@@ -26,7 +26,7 @@
 from spack import *
 
 
-class Openscenegraph(Package):
+class Openscenegraph(CMakePackage):
     """OpenSceneGraph is an open source, high performance 3D graphics toolkit
        that's used in a variety of visual simulation applications."""
 
@@ -36,42 +36,34 @@ class Openscenegraph(Package):
     version('3.2.3', '02ffdad7744c747d8fad0d7babb58427')
     version('3.1.5', '1c90b851b109849c985006486ef59822')
 
-    variant('debug', default=False, description='Builds a debug version of the library')
     variant('shared', default=True, description='Builds a shared version of the library')
 
     depends_on('cmake@2.8.7:', type='build')
     depends_on('qt@4:')
     depends_on('zlib')
 
-    def install(self, spec, prefix):
-        build_type = 'Debug' if '+debug' in spec else 'Release'
+    def cmake_args(self):
+        spec = self.spec
+
         shared_status = 'ON' if '+shared' in spec else 'OFF'
 
-        cmake_args = std_cmake_args[:]
-        cmake_args.extend([
-            '-DCMAKE_BUILD_TYPE={0}'.format(build_type),
+        args = [
             '-DDYNAMIC_OPENSCENEGRAPH={0}'.format(shared_status),
             '-DDYNAMIC_OPENTHREADS={0}'.format(shared_status),
-        ])
+            '-DZLIB_INCLUDE_DIR={0}'.format(spec['zlib'].prefix.include),
+            '-DZLIB_LIBRARY={0}/libz.{1}'.format(spec['zlib'].prefix.lib,
+                                                 dso_suffix),
+            '-DBUILD_OSG_APPLICATIONS=OFF',
+            '-DOSG_NOTIFY_DISABLED=ON',
+            '-DLIB_POSTFIX=',
+        ]
 
         # NOTE: This is necessary in order to allow OpenSceneGraph to compile
         # despite containing a number of implicit bool to int conversions.
         if spec.satisfies('%gcc'):
-            cmake_args.extend([
+            args.extend([
                 '-DCMAKE_C_FLAGS=-fpermissive',
                 '-DCMAKE_CXX_FLAGS=-fpermissive',
             ])
 
-        with working_dir('spack-build', create=True):
-            cmake(
-                '..',
-                '-DZLIB_INCLUDE_DIR={0}'.format(spec['zlib'].prefix.include),
-                '-DZLIB_LIBRARY={0}/libz.{1}'.format(spec['zlib'].prefix.lib,
-                                                     dso_suffix),
-                '-DBUILD_OSG_APPLICATIONS=OFF',
-                '-DOSG_NOTIFY_DISABLED=ON',
-                '-DLIB_POSTFIX=',
-                *cmake_args
-            )
-            make()
-            make('install')
+        return args