zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

casacore: fft implementation default (#22226)

Browse Source 
* Change default FFT implementation to FFTW

To account for the default changing with casacore v3.4.0, as well as the
CMake logic for getting the FFTPack implementation.

* Switch to using spec.satisfies() for Python CMake values
This commit is contained in:
Martin Pokorny 2021-03-20 07:58:56 -06:00 committed by GitHub
parent ec0dc67e73
commit c84c0187ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
var/spack/repos/builtin/packages/casacore/package.py
View File

@ -31,7 +31,7 @@ class Casacore(CMakePackage):
variant('readline', default=True, description='Build readline support')
# see note below about the reason for disabling the "sofa" variant
# variant('sofa', default=False, description='Build SOFA support')
variant('fftw', default=False, description='Build FFTW3 support')
variant('fftw', default=True, description='Build FFTW3 support')
variant('hdf5', default=False, description='Build HDF5 support')
variant('python', default=False, description='Build python support')
@ -65,12 +65,20 @@ def cmake_args(self):
args.append(self.define_from_variant('USE_OPENMP', 'openmp'))
args.append(self.define_from_variant('USE_READLINE', 'readline'))
args.append(self.define_from_variant('USE_HDF5', 'hdf5'))
# fftw3 is used by casacore as the default starting with
# v3.4.0 (although we use fftw3 by default in this Spack
# package), but the old fftpack is still available
if spec.satisfies('@3.4.0:'):
if spec.satisfies('~fftw'):
args.append('-DBUILD_FFTPACK_DEPRECATED=YES')
else:
args.append(self.define_from_variant('USE_FFTW3', 'fftw'))
# Python2 and Python3 binding
if '+python' not in spec:
if spec.satisfies('~python'):
args.extend(['-DBUILD_PYTHON=NO', '-DBUILD_PYTHON3=NO'])
elif spec['python'].version >= Version('3.0.0'):
elif spec.satisfies('^python@3.0.0:'):
args.extend(['-DBUILD_PYTHON=NO', '-DBUILD_PYTHON3=YES'])
else:
args.extend(['-DBUILD_PYTHON=YES', '-DBUILD_PYTHON3=NO'])