zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

audit: detect self-referential depends_on (#42456)

Browse Source
This commit is contained in:
Massimiliano Culpo 2024-02-12 21:56:06 +01:00 committed by GitHub
parent 2a01e9679a
commit cb3c014a43
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lib/spack/spack/audit.py
View File

@ -796,13 +796,33 @@ def check_virtual_with_variants(spec, msg):
except spack.repo.UnknownPackageError: except spack.repo.UnknownPackageError:
# This dependency is completely missing, so report # This dependency is completely missing, so report
# and continue the analysis # and continue the analysis
summary = ( summary = f"{pkg_name}: unknown package '{dep_name}' in 'depends_on' directive"
f"{pkg_name}: unknown package '{dep_name}' in " "'depends_on' directive"
)
details = [f" in {filename}"] details = [f" in {filename}"]
errors.append(error_cls(summary=summary, details=details)) errors.append(error_cls(summary=summary, details=details))
continue continue
# Check for self-referential specs similar to:
#
# depends_on("foo@X.Y", when="^foo+bar")
#
# That would allow clingo to choose whether to have foo@X.Y+bar in the graph.
problematic_edges = [
x for x in when.edges_to_dependencies(dep_name) if not x.virtuals
]
if problematic_edges and not dep.patches:
summary = (
f"{pkg_name}: dependency on '{dep.spec}' when '{when}' is self-referential"
)
details = [
(
f" please specify better using '^[virtuals=...] {dep_name}', or "
f"substitute with an equivalent condition on '{pkg_name}'"
),
f" in {filename}",
]
errors.append(error_cls(summary=summary, details=details))
continue
# check variants # check variants
dependency_variants = dep.spec.variants dependency_variants = dep.spec.variants
for name, value in dependency_variants.items(): for name, value in dependency_variants.items():