package/libspatialite: add conflict, new version (#42573)

* package/libspatialite: add conflict, new version

* depends on new version of freexl

* fix bug

* remove manual download stuff

* improve style

* first depracate

* [@spackbot] updating style on behalf of Sinan81

* get rid of conflict, reorder deps

* remove manual download

---------

Co-authored-by: sbulut <sbulut@3vgeomatics.com>
Co-authored-by: Sinan81 <Sinan81@users.noreply.github.com>

var/spack/repos/builtin/packages/libspatialite/package.py

@@ -3,8 +3,6 @@
 #
 # SPDX-License-Identifier: (Apache-2.0 OR MIT)
 
-import os
-
 from spack.package import *
 
 
@@ -14,37 +12,37 @@ class Libspatialite(AutotoolsPackage):
 
     homepage = "https://www.gaia-gis.it"
     url = "https://www.gaia-gis.it/gaia-sins/libspatialite-sources/libspatialite-4.3.0a.tar.gz"
-    manual_download = True
 
     license("MPL-1.1")
 
+    version("5.1.0", sha256="43be2dd349daffe016dd1400c5d11285828c22fea35ca5109f21f3ed50605080")
     version("5.0.1", sha256="eecbc94311c78012d059ebc0fae86ea5ef6eecb13303e6e82b3753c1b3409e98")
+    version(
+        "5.0.0-beta0",
+        sha256="caacf5378a5cfab9b8e98bb361e2b592e714e21f5c152b795df80d0ab1da1c42",
+        deprecated=True,
+    )
     version("5.0.0", sha256="7b7fd70243f5a0b175696d87c46dde0ace030eacc27f39241c24bac5dfac6dac")
-    # Must download manually from:
-    #     https://www.gaia-gis.it/fossil/libspatialite/info/c7f67038bf06d98d
-    # For instructions on the file:// below..
-    #     https://github.com/spack/spack/issues/2489
     version(
-        "5.0.0.2.c7f67038bf",
+        "4.3.0a",
-        sha256="f8100f71b769c7db066c6f938af6b00e920e4b90ac14c00a4f3ed7171565caab",
+        sha256="88900030a4762904a7880273f292e5e8ca6b15b7c6c3fb88ffa9e67ee8a5a499",
-        url="file://%s/SpatiaLite-c7f67038bf.tar.gz" % os.getcwd(),
+        deprecated=True,
     )
-
     version(
-        "5.0.0-beta0", sha256="caacf5378a5cfab9b8e98bb361e2b592e714e21f5c152b795df80d0ab1da1c42"
+        "3.0.1",
+        sha256="4983d6584069fd5ff0cfcccccee1015088dab2db177c0dc7050ce8306b68f8e6",
+        deprecated=True,
     )
-    version("4.3.0a", sha256="88900030a4762904a7880273f292e5e8ca6b15b7c6c3fb88ffa9e67ee8a5a499")
-    version("3.0.1", sha256="4983d6584069fd5ff0cfcccccee1015088dab2db177c0dc7050ce8306b68f8e6")
 
     depends_on("pkgconfig", type="build")
-    depends_on("sqlite+rtree")
-    depends_on("proj@:5", when="@:4")
-    # PROJ.6 is OK w/ newer versions
-    # https://www.gaia-gis.it/fossil/libspatialite/wiki?name=PROJ.6
-    depends_on("proj")
-    depends_on("geos")
     depends_on("freexl")
+    depends_on("freexl@2:", when="@5.1:")
+    depends_on("geos")
+    depends_on("geos@:3.9", when="@:5.0.0")
     depends_on("iconv")
+    depends_on("librttopo", when="@5.0.1:")
     depends_on("libxml2")
     depends_on("minizip", when="@5.0.0:")
-    depends_on("librttopo", when="@5.0.1:")
+    depends_on("proj")
+    depends_on("proj@:5", when="@:4")
+    depends_on("sqlite+rtree")