zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

install: one less concretization when installing from file

Browse Source
This commit is contained in:
Massimiliano Culpo 2020-10-31 22:30:28 +01:00 committed by Todd Gamblin
parent 27bb970a97
commit ccb537479a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/spack/spack/cmd/install.py
View File

@ -367,14 +367,15 @@ def install(parser, args, **kwargs):
with open(file, 'r') as f: with open(file, 'r') as f:
s = spack.spec.Spec.from_yaml(f) s = spack.spec.Spec.from_yaml(f)
if s.concretized().dag_hash() != s.dag_hash(): concretized = s.concretized()
if concretized.dag_hash() != s.dag_hash():
msg = 'skipped invalid file "{0}". ' msg = 'skipped invalid file "{0}". '
msg += 'The file does not contain a concrete spec.' msg += 'The file does not contain a concrete spec.'
tty.warn(msg.format(file)) tty.warn(msg.format(file))
continue continue
abstract_specs.append(s) abstract_specs.append(s)
specs.append(s.concretized()) specs.append(concretized)
if len(specs) == 0: if len(specs) == 0:
tty.die('The `spack install` command requires a spec to install.') tty.die('The `spack install` command requires a spec to install.')