Revert "cc: work around -v split between ld and ccld" (#42196)

lib/spack/env/cc

@@ -283,19 +283,10 @@ esac
 if [ -z "$mode" ] || [ "$mode" = ld ]; then
     for arg in "$@"; do
         case $arg in
-            -V|--version|-dumpversion)
+            -v|-V|--version|-dumpversion)
                 mode=vcheck
                 break
                 ;;
-            -v)
-                # NOTE(trws): -v is verbose on gcc, not version, this is an ld-mode flag only
-                # -V is invalid on gcc but may be valid on some other compiler so leaving that in
-                case "$mode" in
-                    ld)
-                        mode=vcheck
-                        break
-                        ;;
-                esac
         esac
     done
 fi

lib/spack/spack/test/cc.py

@@ -244,10 +244,10 @@ def test_no_wrapper_environment():
 def test_vcheck_mode(wrapper_environment):
     assert dump_mode(cc, ["-I/include", "--version"]) == "vcheck"
     assert dump_mode(cc, ["-I/include", "-V"]) == "vcheck"
+    assert dump_mode(cc, ["-I/include", "-v"]) == "vcheck"
     assert dump_mode(cc, ["-I/include", "-dumpversion"]) == "vcheck"
     assert dump_mode(cc, ["-I/include", "--version", "-c"]) == "vcheck"
     assert dump_mode(cc, ["-I/include", "-V", "-o", "output"]) == "vcheck"
-    assert dump_mode(ld, ["-I/include", "-v"]) == "vcheck"
 
 
 def test_cpp_mode(wrapper_environment):