zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update recipe for cgns to avoid build warnings/errors: (#5382)

Browse Source 
+ The recipe for cgns seems to be wrong. CMake complains about variables set but
  not used (`HDF5_NEEDS_ZLIB`, `HDF5_NEEDS_MPI` and `HDF5_NEEDS_SZIP`) and fails
  to find HDF5.
+ This change set removes these variables from the cmake configure line,
  replacing them with `'-DHDF5_DIR=%s' % spec['hdf5'].prefix`
+ cgns also has trouble with parallel make, so I set `parallel = False`.
This commit is contained in:
Kelly (KT) Thompson 2017-09-20 18:21:14 -06:00 committed by Christoph Junghans
parent 02b7e38bb2
commit d10aa385fb
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
var/spack/repos/builtin/packages/cgns/package.py
View File

@ -40,6 +40,8 @@ class Cgns(CMakePackage):
depends_on('cmake@2.8:', type='build')
depends_on('hdf5', when='+hdf5')
parallel = False
def cmake_args(self):
spec = self.spec
cmake_args = []
@ -52,18 +54,9 @@ def cmake_args(self):
if '+hdf5' in spec:
cmake_args.extend([
'-DCGNS_ENABLE_HDF5=ON',
'-DHDF5_NEEDS_ZLIB=ON'
'-DHDF5_DIR=%s' % spec['hdf5'].prefix
])
if spec.satisfies('^hdf5+mpi'):
cmake_args.append('-DHDF5_NEEDS_MPI=ON')
else:
cmake_args.append('-DHDF5_NEEDS_MPI=OFF')
if spec.satisfies('^hdf5+szip'):
cmake_args.append('-DHDF5_NEEDS_SZIP=ON')
else:
cmake_args.append('-DHDF5_NEEDS_SZIP=OFF')
else:
cmake_args.append('-DCGNS_ENABLE_HDF5=OFF')