From d2f269ed7bfb314bb76e9e88f62a14bf690b2021 Mon Sep 17 00:00:00 2001 From: Jordan Galby <67924449+Jordan474@users.noreply.github.com> Date: Wed, 7 Aug 2024 12:12:56 +0200 Subject: [PATCH] Fix SIP build system installing files into python-venv (#45360) For example: spack install py-pyqt5 or py-pyqt6 would install pylupdate5 pyrcc5 and pyuic5 into in python-venv's install prefix. Fix https://github.com/spack/spack/issues/45359 --- lib/spack/spack/build_systems/sip.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/spack/spack/build_systems/sip.py b/lib/spack/spack/build_systems/sip.py index 5d93e23ac2d..f1263c12a60 100644 --- a/lib/spack/spack/build_systems/sip.py +++ b/lib/spack/spack/build_systems/sip.py @@ -139,6 +139,10 @@ def configure(self, pkg, spec, prefix): args = ["--verbose", "--target-dir", inspect.getmodule(self.pkg).python_platlib] args.extend(self.configure_args()) + # https://github.com/Python-SIP/sip/commit/cb0be6cb6e9b756b8b0db3136efb014f6fb9b766 + if spec["py-sip"].satisfies("@6.1.0:"): + args.extend(["--scripts-dir", pkg.prefix.bin]) + sip_build = Executable(spec["py-sip"].prefix.bin.join("sip-build")) sip_build(*args)