zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

llvm-amdgpu: Conflict with MacOS (#45633)

Browse Source 
Currently, the llvm-amdgpu package doesn't compile on MacOS, but it is
also not marked as a conflict. This causes problems because it seems
that Spack is very happy to pull in llvm-amdgpu as the default package
to satisfy any virtual libllvm dependency, which can cause dependent
specs to fail to install on MacOS. This commit marks a conflict between
this llvm package and the Darwin platform.
This commit is contained in:
Stephen Nicholas Swatman 2024-08-22 19:14:20 +02:00 committed by GitHub
parent 1bcb1fcebc
commit d5eefcba87
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
var/spack/repos/builtin/packages/llvm-amdgpu/package.py
View File

@ -75,6 +75,11 @@ class LlvmAmdgpu(CMakePackage, CompilerPackage):
depends_on("ncurses+termlib", type="link") depends_on("ncurses+termlib", type="link")
depends_on("pkgconfig", type="build") depends_on("pkgconfig", type="build")
# This flavour of LLVM doesn't work on MacOS, so we should ensure that it
# isn't used to satisfy any of the libllvm dependencies on the Darwin
# platform.
conflicts("platform=darwin")
# OpenMP clang toolchain looks for bitcode files in llvm/bin/../lib # OpenMP clang toolchain looks for bitcode files in llvm/bin/../lib
# as per 5.2.0 llvm code. It used to be llvm/bin/../lib/libdevice. # as per 5.2.0 llvm code. It used to be llvm/bin/../lib/libdevice.
# Below patch is to look in the old path. # Below patch is to look in the old path.