From d68e1c976d3a2fe3181b7aeb6374eaf4d393bbf4 Mon Sep 17 00:00:00 2001 From: Peter Josef Scheibel Date: Wed, 19 Oct 2022 14:39:49 -0600 Subject: [PATCH] add note for consideration --- lib/spack/spack/package_base.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/spack/spack/package_base.py b/lib/spack/spack/package_base.py index 6d17f0d3c0f..105e1ad85e0 100644 --- a/lib/spack/spack/package_base.py +++ b/lib/spack/spack/package_base.py @@ -700,6 +700,8 @@ def __init__(self, spec): settings = spack.config.get("packages").get(spec.name, {}).get("package_attributes", {}) for key, val in settings.items(): setattr(self, key, val) + # Note: the potential issue with setting these attributes here vs. + # in Repo.get is that subclasses could override these properties @classmethod def possible_dependencies(