add note for consideration

lib/spack/spack/package_base.py

@@ -700,6 +700,8 @@ def __init__(self, spec):
         settings = spack.config.get("packages").get(spec.name, {}).get("package_attributes", {})
         for key, val in settings.items():
             setattr(self, key, val)
+        # Note: the potential issue with setting these attributes here vs.
+        # in Repo.get is that subclasses could override these properties
 
     @classmethod
     def possible_dependencies(