From d792121cdeec8f33a2877054040f80dffeb076ed Mon Sep 17 00:00:00 2001 From: Gregory Becker Date: Tue, 22 Apr 2025 17:29:01 -0700 Subject: [PATCH] conditional deps: bugfix for type mismatch in _add_dependency Signed-off-by: Gregory Becker --- lib/spack/spack/spec.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/spack/spack/spec.py b/lib/spack/spack/spec.py index 2c7139523aa..12ecfa77bce 100644 --- a/lib/spack/spack/spec.py +++ b/lib/spack/spack/spec.py @@ -1780,6 +1780,9 @@ def _add_dependency( direct: if True denotes a direct dependency (associated with the % sigil) when: if non-None, condition under which dependency holds """ + if when is None: + when = Spec() + if spec.name not in self._dependencies or not spec.name: self.add_dependency_edge( spec, depflag=depflag, virtuals=virtuals, direct=direct, when=when @@ -1839,6 +1842,9 @@ def add_dependency_edge( direct: if True denotes a direct dependency when: if non-None, condition under which dependency holds """ + if when is None: + when = Spec() + # Check if we need to update edges that are already present selected = self._dependencies.select(child=dependency_spec.name) for edge in selected: