containerize: strip binaries in a less aggressive way (#36683)

This commit is contained in:
Massimiliano Culpo
2023-04-13 17:09:34 +02:00
committed by GitHub
parent b940468890
commit d918ae0bde
4 changed files with 24 additions and 2 deletions

View File

@@ -116,3 +116,14 @@ def test_error_message_invalid_os(minimal_configuration):
minimal_configuration["spack"]["container"]["images"]["os"] = "invalid:1"
with pytest.raises(ValueError, match="invalid operating system"):
writers.create(minimal_configuration)
@pytest.mark.regression("34629,18030")
def test_not_stripping_all_symbols(minimal_configuration):
"""Tests that we are not stripping all symbols, so that libraries can still be
used for linking.
"""
minimal_configuration["spack"]["container"]["strip"] = True
content = writers.create(minimal_configuration)()
assert "xargs strip" in content
assert "xargs strip -s" not in content

View File

@@ -40,3 +40,14 @@ def test_singularity_specific_properties(properties, expected, singularity_confi
writer = writers.create(singularity_configuration)
for name, value in expected.items():
assert getattr(writer, name) == value
@pytest.mark.regression("34629,18030")
def test_not_stripping_all_symbols(singularity_configuration):
"""Tests that we are not stripping all symbols, so that libraries can still be
used for linking.
"""
singularity_configuration["spack"]["container"]["strip"] = True
content = writers.create(singularity_configuration)()
assert "xargs strip" in content
assert "xargs strip -s" not in content